impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] KUDU-1929: [rpc] Allow using encrypted private keys for TLS
Date Sun, 20 Aug 2017 01:11:40 GMT
Hello Sailesh Mukil, Kudu Jenkins,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/7741

to review the following change.

Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS
......................................................................

KUDU-1929: [rpc] Allow using encrypted private keys for TLS

* This patch adds a new flag for a "password command" for the RPC
  private key.

 * This also makes the webserver move to using the new function
   GetPasswordFromShellCommand().

 * This also consolidates certificates from security-test-util into
   security/tests/test_certs

Testing: Adds 2 tests. One to verify that RPCs work when providing
the right password for password protected private keys, and one to
verify that the Messenger does not startup if the wrong password
is provided when using a password protected private key.

Change-Id: Ifd6369581fa426ceab11e4a10441658c7da47e81
Reviewed-on: http://gerrit.cloudera.org:8080/6635
Tested-by: Kudu Jenkins
Reviewed-by: Sailesh Mukil <sailesh@cloudera.com>
---
M be/src/kudu/rpc/messenger.cc
M be/src/kudu/rpc/rpc-test.cc
M be/src/kudu/security/crypto.cc
M be/src/kudu/security/crypto.h
M be/src/kudu/security/openssl_util.cc
M be/src/kudu/security/openssl_util.h
M be/src/kudu/security/openssl_util_bio.h
M be/src/kudu/security/security-test-util.cc
M be/src/kudu/security/security-test-util.h
M be/src/kudu/security/test/test_certs.cc
M be/src/kudu/security/test/test_certs.h
M be/src/kudu/security/tls_context.cc
M be/src/kudu/security/tls_context.h
13 files changed, 329 insertions(+), 144 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/7741/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd6369581fa426ceab11e4a10441658c7da47e81
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>

Mime
View raw message