impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] tidy: enable rule for constant naming
Date Sun, 20 Aug 2017 01:11:34 GMT
Hello Adar Dembo, Kudu Jenkins,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/7740

to review the following change.

Change subject: tidy: enable rule for constant naming
......................................................................

tidy: enable rule for constant naming

This enables the rule that constants should be named kFooBar and fixes
the cases where we didn't adhere to this. The fixes were started using
clang-tidy --fix, but it wasn't very good at finding all references, so
I did some by-hand tweaking to get it to compile after that.

I left a few aberrations in gutil, etc, but this should be at least a
good cleanup.

Change-Id: I7971659ef3152580d44d6ddfb18be7ebf41052c7
Reviewed-on: http://gerrit.cloudera.org:8080/7158
Reviewed-by: Adar Dembo <adar@cloudera.com>
Tested-by: Kudu Jenkins
---
M be/src/kudu/rpc/protoc-gen-krpc.cc
M be/src/kudu/rpc/request_tracker-test.cc
M be/src/kudu/rpc/request_tracker.cc
M be/src/kudu/rpc/request_tracker.h
M be/src/kudu/rpc/retriable_rpc.h
M be/src/kudu/security/ca/cert_management.cc
M be/src/kudu/security/cert.cc
M be/src/kudu/security/crypto.cc
M be/src/kudu/security/openssl_util.h
M be/src/kudu/security/openssl_util_bio.h
M be/src/kudu/security/tls_context.cc
M be/src/kudu/util/debug/trace_event_impl.cc
M be/src/kudu/util/maintenance_manager.cc
M be/src/kudu/util/maintenance_manager.h
M be/src/kudu/util/mem_tracker-test.cc
M be/src/kudu/util/os-util.cc
M be/src/kudu/util/process_memory.cc
M be/src/kudu/util/rle-test.cc
18 files changed, 85 insertions(+), 85 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/7740/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7971659ef3152580d44d6ddfb18be7ebf41052c7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Adar Dembo <adar@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

Mime
View raw message