impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5775: (Addendum) Make SSL cluster actually come up in test client ssl.py
Date Sat, 19 Aug 2017 00:12:17 GMT
Henry Robinson has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7732

Change subject: IMPALA-5775: (Addendum) Make SSL cluster actually come up in test_client_ssl.py
......................................................................

IMPALA-5775: (Addendum) Make SSL cluster actually come up in test_client_ssl.py

The non-wildcard certs in test_client_ssl.py require that the hostname
of the process is 'localhost' for clients to validate them. This wasn't
the case for one test, and so the cluster wouldn't actually
start. Although the test would still pass (because the shell wasn't
actually checking the certificate), it's better hygiene to have the
cluster correctly configured to make sure we're testing what we think we
are.

Testing: test continues to pass

Change-Id: Idad8bbf3b8be853d3406bcbaed24909501500ea9
---
M tests/custom_cluster/test_client_ssl.py
1 file changed, 8 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/7732/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idad8bbf3b8be853d3406bcbaed24909501500ea9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>

Mime
View raw message