impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5653: Remove "unlimited" process mem limit option
Date Thu, 31 Aug 2017 03:42:46 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5653: Remove "unlimited" process mem_limit option
......................................................................


IMPALA-5653: Remove "unlimited" process mem_limit option

This was deprecated in 2.10. Now we can disable it.

Testing:
Started a minicluster with --mem_limit="" and --mem_limit=-1,
confirmed that it didn't start up and logged a reasonable
error in both cases.

  E0825 09:23:59.749104 32708 impalad-main.cc:95] Impalad services did
    not start correctly, exiting.  Error: The process memory limit
    (--mem_limit) must be a positive bytes value or percentage: -1

Change-Id: Ifb235ae34ce8d2aff37f0fa0c218419da01b30f3
Reviewed-on: http://gerrit.cloudera.org:8080/7828
Reviewed-by: Dan Hecht <dhecht@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/runtime/exec-env.cc
1 file changed, 10 insertions(+), 16 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Dan Hecht: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb235ae34ce8d2aff37f0fa0c218419da01b30f3
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins

Mime
View raw message