impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5617: Include full workload name in tpch nested query filenames
Date Thu, 31 Aug 2017 01:08:41 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5617: Include full workload name in tpch_nested query filenames
......................................................................


IMPALA-5617: Include full workload name in tpch_nested query filenames

The concurrent test driver did not pick them up because the name
prefix did not match the workload dirname.  The query test driver
used a hardcoded prefix.

Testing done: Ran tests/stress/concurrent_select.py,
tests/query_test/test_tpch_nested_queries.py locally; latter
passed, former hit IMPALA-5855 after correctly locating all 22
new tpch_nested query files.

Change-Id: Ie067b201ae20b4f4c61a98be7ac1ec5a3f8febd8
Reviewed-on: http://gerrit.cloudera.org:8080/7891
Reviewed-by: Michael Brown <mikeb@cloudera.com>
Reviewed-by: David Knupp <dknupp@cloudera.com>
Tested-by: Impala Public Jenkins
---
R testdata/workloads/tpch_nested/queries/tpch_nested-q1.test
R testdata/workloads/tpch_nested/queries/tpch_nested-q10.test
R testdata/workloads/tpch_nested/queries/tpch_nested-q11.test
R testdata/workloads/tpch_nested/queries/tpch_nested-q12.test
R testdata/workloads/tpch_nested/queries/tpch_nested-q13.test
R testdata/workloads/tpch_nested/queries/tpch_nested-q14.test
R testdata/workloads/tpch_nested/queries/tpch_nested-q15.test
R testdata/workloads/tpch_nested/queries/tpch_nested-q16.test
R testdata/workloads/tpch_nested/queries/tpch_nested-q17.test
R testdata/workloads/tpch_nested/queries/tpch_nested-q18.test
R testdata/workloads/tpch_nested/queries/tpch_nested-q19.test
R testdata/workloads/tpch_nested/queries/tpch_nested-q2.test
R testdata/workloads/tpch_nested/queries/tpch_nested-q20.test
R testdata/workloads/tpch_nested/queries/tpch_nested-q21.test
R testdata/workloads/tpch_nested/queries/tpch_nested-q22.test
R testdata/workloads/tpch_nested/queries/tpch_nested-q3.test
R testdata/workloads/tpch_nested/queries/tpch_nested-q4.test
R testdata/workloads/tpch_nested/queries/tpch_nested-q5.test
R testdata/workloads/tpch_nested/queries/tpch_nested-q6.test
R testdata/workloads/tpch_nested/queries/tpch_nested-q7.test
R testdata/workloads/tpch_nested/queries/tpch_nested-q8.test
R testdata/workloads/tpch_nested/queries/tpch_nested-q9.test
M tests/query_test/test_tpch_nested_queries.py
23 files changed, 22 insertions(+), 22 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  David Knupp: Looks good to me, approved
  Michael Brown: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.cloudera.org:8080/7891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie067b201ae20b4f4c61a98be7ac1ec5a3f8febd8
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Wood <twood@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Mulder <mmulder@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Tim Wood <twood@cloudera.com>

Mime
View raw message