impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0
Date Wed, 30 Aug 2017 22:45:57 GMT
Hello Bharath Vissapragada,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7866

to look at the new patch set (#2).

Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0
......................................................................

IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0

Rather than check for OpenSSL w/TLSv1.1+ support at compile time, we
altered Thrift-0.9.0-p11 to compile on all versions, and fail with an
error if an unsupported version is requested at runtime. This patch
is the Impala-side counterpart to that work.

We assume that tests will be run on the same machine that built Impala,
so still execute slightly different tests depending on the detected
OpenSSL version.

Also include corresponding changes to Squeasel from this commit:

https://github.com/cloudera/squeasel/commit/9335b8

Testing: New webserver and thrift-server tests.

TODO Toolchain will need a version bump when thrift-0.9.0-p11 is approved.

Change-Id: I20c5d39c0c4ae9c5445dd3ee3b175fe337a5728d
---
M be/src/rpc/thrift-server-test.cc
M be/src/rpc/thrift-server.cc
M be/src/service/impala-server.cc
M be/src/thirdparty/squeasel/squeasel.c
M be/src/util/webserver-test.cc
M bin/impala-config.sh
6 files changed, 60 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/7866/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7866
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I20c5d39c0c4ae9c5445dd3ee3b175fe337a5728d
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>

Mime
View raw message