impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5863: Include-what-you-use for Kudu client
Date Wed, 30 Aug 2017 21:10:46 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5863: Include-what-you-use for Kudu client
......................................................................


IMPALA-5863: Include-what-you-use for Kudu client

A recent commit in Kudu removed some unnecessary includes from Kudu
client headers to reduce compile times. We were implicitly relying on
those includes, so before we upgrade to a newer version of the client
we need to make the includes explicit on our side to avoid breaking
compilation.

Change-Id: Ibd041b783a9b7764f4b251291e0be5ed000485ce
Reviewed-on: http://gerrit.cloudera.org:8080/7872
Reviewed-by: Matthew Jacobs <mj@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/exec/kudu-table-sink.cc
M be/src/exec/kudu-util.cc
M be/src/exprs/kudu-partition-expr.h
3 files changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Matthew Jacobs: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd041b783a9b7764f4b251291e0be5ed000485ce
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>

Mime
View raw message