impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Wood (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5617: Include full workload name in tpch nested query filenames
Date Wed, 30 Aug 2017 19:20:17 GMT
Tim Wood has posted comments on this change.

Change subject: IMPALA-5617: Include full workload name in tpch_nested query filenames
......................................................................


Patch Set 3:

(3 comments)

Replied via Gerrit controls.

http://gerrit.cloudera.org:8080/#/c/7891/2//COMMIT_MSG
Commit Message:

PS2, Line 7: IMPALA-5617: Include full workload name in tpch_nested 
> Maybe:
Done


Line 11: used a hardcoded prefix.
> Can you please add a testing done section here?
Done


http://gerrit.cloudera.org:8080/#/c/7891/2/tests/query_test/test_tpch_nested_queries.py
File tests/query_test/test_tpch_nested_queries.py:

PS2, Line 37: sel
> get_workload() already returns a string. Wrapping this in str() seems redun
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie067b201ae20b4f4c61a98be7ac1ec5a3f8febd8
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Wood <twood@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Matthew Mulder <mmulder@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Tim Wood <twood@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message