impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5617: Include full workload name in tpch nested query filenames
Date Wed, 30 Aug 2017 19:18:44 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-5617: Include full workload name in tpch_nested query filenames
......................................................................


Patch Set 3:

> MB: Reworded summary and added testing summary.
 > DK: Removed the str()s.  I've run into cases where Python tried to
 > use the wrong operator on a function value, so I was being
 > paranoid.  Re-ran test.

Code review convention is to respond to the inline comments directly. Gerrit facilitates this
quite well. For most things that you fix, you can just click Done. Or, you leave have a short
reply if you disagree or fix things in a different way. If you look at other reviews for the
Impala-ASF project, you'll see similar behavior.

Unlike Github, your comments will get batched up and unpublished until you hit Reply near
the top of the page. Note that sometimes you have to change the Patch Set number to find inline
comments. That's at the top right of the page.

-- 
To view, visit http://gerrit.cloudera.org:8080/7891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie067b201ae20b4f4c61a98be7ac1ec5a3f8febd8
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Wood <twood@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Matthew Mulder <mmulder@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Tim Wood <twood@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message