impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5617: Rename tpch nested query files per pattern
Date Wed, 30 Aug 2017 18:55:23 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-5617: Rename tpch_nested query files per pattern
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7891/2//COMMIT_MSG
Commit Message:

PS2, Line 7: IMPALA-5617: Rename tpch_nested query files per pattern
Maybe:

  IMPALA-5617: include full workload name in tpch_nested query files

This is a clearer summary of what is happening in the change. Clear summaries are useful for
"git log --oneline" and similar perusals of a repository.


Line 11: 
Can you please add a testing done section here?


-- 
To view, visit http://gerrit.cloudera.org:8080/7891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie067b201ae20b4f4c61a98be7ac1ec5a3f8febd8
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Wood <twood@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Matthew Mulder <mmulder@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Tim Wood <twood@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message