impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5617: Rename tpch nested query files per pattern
Date Wed, 30 Aug 2017 18:48:04 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-5617: Rename tpch_nested query files per pattern
......................................................................


Patch Set 1:

Hi,

Don't forget to use the same Change-Id when updating Gerrit reviews. This is typically achieved
by the following:

1. Using "git commit --amend". Useful for small updates to patch sets. You can even just update
the commit message. Make sure to keep the original Change-Id in the message.

2. "git rebase -i". Useful for larger updates. Make sure you preserve the Change-Id. Note
that you can rebase against the same parent as you had before: it needn't be a new commit
hash of master.

The key is to preserve the same Change-Id line in the commit message.

I suggest you abandon this review.

-- 
To view, visit http://gerrit.cloudera.org:8080/7899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6403a3b070dc56aac0467f2f9bc309330dd7687d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Wood <twood@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message