impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4826: Fix wrong scan result on repeated root schema in Parquet.
Date Wed, 30 Aug 2017 17:51:56 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4826: Fix wrong scan result on repeated root schema in Parquet.
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7870/1//COMMIT_MSG
Commit Message:

Line 9: Having the repetition level set to REPEATED on the root schema
> Well, IMPALA-4826 contains a link to the Parquet Jira (that explains why th
My reasoning was that it makes the commit message more self contained. When reading it, I
wondered why we decided to ignore the field in the root schema. The explanation is that the
parquet format says that those fields should not be set.


http://gerrit.cloudera.org:8080/#/c/7870/2//COMMIT_MSG
Commit Message:

PS2, Line 7: wrong scan result
Here it says wrong result, but below it says that the queries failed. Can you make both consistent?


-- 
To view, visit http://gerrit.cloudera.org:8080/7870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ea84589e1d122ad9d43adde46893ec0ecc5f9c4
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Gabor Kaszab <gaborkaszab@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <gaborkaszab@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <laszlo.gaal@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message