impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip Zeyliger (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5854: Update external hadoop versions
Date Wed, 30 Aug 2017 17:31:20 GMT
Philip Zeyliger has posted comments on this change.

Change subject: IMPALA-5854: Update external hadoop versions
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7892/1/bin/impala-config.sh
File bin/impala-config.sh:

PS1, Line 126: export KUDU_JAVA_VERSION=1.5.0-cdh5.14.0-SNAPSHOT
> I think they may have goofed in publishing multiple versions, 1.5.0-cdh5.14
In a previous life, we had a test that made sure that -SNAPSHOT artifacts being taken from
Maven were "recent." Basically, the premise is that if you're relying on a SNAPSHOT artifact,
you're grabbing something that's in active development, and should have been built within
the last few weeks. The reason this test was added was similar to the one here: some dependency
may bump its version, but the old SNAPSHOT jars continue to live forever, and you're not aware
that you've started to slip far far behind.


-- 
To view, visit http://gerrit.cloudera.org:8080/7892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ab9512c3fa3e94c3a4fa9eeb49ff5563a114954
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message