impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3877: support unpatched LLVM
Date Wed, 30 Aug 2017 17:14:41 GMT
Tim Armstrong has uploaded a new patch set (#3).

Change subject: IMPALA-3877: support unpatched LLVM
......................................................................

IMPALA-3877: support unpatched LLVM

The p1 patch we use for LLVM avoided merging of structurally
identical Struct types in unpredictable ways when linking in
IR UDF modules. This avoided hitting type assertions when
generating calls to IR UDfs.

This implements an alternative solution, which is to bitcast
the arguments when calling IR UDFs.

Change-Id: Ie662fb702c39573fe511c39fc8eae2e6f887c262
---
M be/src/codegen/CMakeLists.txt
M be/src/codegen/codegen-anyval.cc
A be/src/codegen/codegen-util.cc
A be/src/codegen/codegen-util.h
M be/src/exprs/expr-codegen-test.cc
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M testdata/workloads/functional-query/queries/QueryTest/admission-reject-min-reservation.test
8 files changed, 159 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/7836/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie662fb702c39573fe511c39fc8eae2e6f887c262
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message