impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5850: Cast sender partition exprs under unions.
Date Wed, 30 Aug 2017 16:05:25 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-5850: Cast sender partition exprs under unions.
......................................................................


Patch Set 1:

(2 comments)

Thanks for the speedy review!

http://gerrit.cloudera.org:8080/#/c/7884/1/fe/src/main/java/org/apache/impala/planner/PlanFragment.java
File fe/src/main/java/org/apache/impala/planner/PlanFragment.java:

PS1, Line 184: In particular, partitioned hash joins under a union are
             :    * treated as different series of joins (could have different data partitions).
> Can you expand the comment to explain what 'node' represents? Also, that pa
Agree with both suggestions. Done.


http://gerrit.cloudera.org:8080/#/c/7884/1/testdata/workloads/functional-query/queries/QueryTest/joins.test
File testdata/workloads/functional-query/queries/QueryTest/joins.test:

PS1, Line 761:  
> nit: extra space
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0aa801bcad8c2324d848349c7967d949224404e0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message