impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2810: Remove column stats restoration when altering table
Date Wed, 30 Aug 2017 04:12:47 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-2810: Remove column stats restoration when altering table
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7857/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

Line 2191
Awesome! Nice to get rid of this.


http://gerrit.cloudera.org:8080/#/c/7857/1/testdata/workloads/functional-query/queries/QueryTest/alter-table.test
File testdata/workloads/functional-query/queries/QueryTest/alter-table.test:

Line 1283: # IMPALA-2810: Error message when moving a partitioned table from one database
to another
Use a similar comment and test flow as the one from IMPALA-1711. See L763 in this file. I
think we should do the exact same testing as in IMPALA-1711, except for a partitioned table.


-- 
To view, visit http://gerrit.cloudera.org:8080/7857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ca7063ca1aa9faceed9568d22740d91b6dc20d3
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message