impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4856: Rename thrift-deps to gen-deps
Date Wed, 30 Aug 2017 00:26:53 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4856: Rename thrift-deps to gen-deps

IMPALA-4856: Rename thrift-deps to gen-deps

As a preparation to start generating Protobuf files
for IMPALA-4856, this change introduces a new build
target "gen-deps" which serves as an umbrella for all
build targets of generated code. For now, it only
includes thrift-deps and protobuf targets will be added
in the future.

Change-Id: I360c63773efdeab4c26ca96b915e0c8d0ce2b9c9
Reviewed-by: Lars Volker <>
Reviewed-by: Tim Armstrong <>
Tested-by: Impala Public Jenkins
M CMakeLists.txt
M be/src/catalog/CMakeLists.txt
M be/src/codegen/CMakeLists.txt
M be/src/common/CMakeLists.txt
M be/src/exec/CMakeLists.txt
M be/src/experiments/CMakeLists.txt
M be/src/exprs/CMakeLists.txt
M be/src/rpc/CMakeLists.txt
M be/src/runtime/CMakeLists.txt
M be/src/runtime/bufferpool/CMakeLists.txt
M be/src/scheduling/CMakeLists.txt
M be/src/service/CMakeLists.txt
M be/src/statestore/CMakeLists.txt
M be/src/testutil/CMakeLists.txt
M be/src/transport/CMakeLists.txt
M be/src/udf/CMakeLists.txt
M be/src/udf_samples/CMakeLists.txt
M be/src/util/CMakeLists.txt
M ext-data-source/CMakeLists.txt
19 files changed, 33 insertions(+), 30 deletions(-)

  Impala Public Jenkins: Verified
  Lars Volker: Looks good to me, but someone else must approve
  Tim Armstrong: Looks good to me, approved

To view, visit
To unsubscribe, visit

Gerrit-MessageType: merged
Gerrit-Change-Id: I360c63773efdeab4c26ca96b915e0c8d0ce2b9c9
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Sailesh Mukil <>
Gerrit-Reviewer: Tim Armstrong <>

View raw message