impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5857: avoid invalid free of hedged read metrics
Date Tue, 29 Aug 2017 22:51:39 GMT
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-5857: avoid invalid free of hedged read metrics
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7885/1/be/src/runtime/disk-io-mgr-scan-range.cc
File be/src/runtime/disk-io-mgr-scan-range.cc:

PS1, Line 354: struct hdfsHedgedReadMetrics* hedged_metrics;
Would it be less confusing if we just initialized 'hedged_metrics' to NULL and left hdfsFreeHedgedReadMetrics()
where it was?


-- 
To view, visit http://gerrit.cloudera.org:8080/7885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93baf3b672429c0283d7f031ff302aca31e05be4
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message