impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0
Date Tue, 29 Aug 2017 19:47:30 GMT
Hello Sailesh Mukil,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7859

to look at the new patch set (#5).

Change subject: IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0
......................................................................

IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0

Thrift commit taken from:

https://github.com/henryr/thrift/commit/d828da9

"This patch slightly changes the TLS configuration code to remove the
compile-time checks that were used to disable 1.1+ support based on the
OpenSSL library on the build machine.

Instead, we define the symbols we need ourselves if necessary, and rely
on runtime behaviour to catch errors or unsupported configurations."

Change-Id: I437703b2221cba6a2c3079c540ccbda571f8db0e
---
M buildall.sh
A source/thrift/thrift-0.9.0-patches/0011-CLD-Patch-11-IMPALA-5849-Don-t-use-compile-time-chec.patch
2 files changed, 93 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/59/7859/5
-- 
To view, visit http://gerrit.cloudera.org:8080/7859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I437703b2221cba6a2c3079c540ccbda571f8db0e
Gerrit-PatchSet: 5
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>

Mime
View raw message