impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0
Date Tue, 29 Aug 2017 18:05:11 GMT
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7866/1//COMMIT_MSG
Commit Message:

Line 25: 
Could you add in the commit message what kind of error messages to expect when using unsupported
TLS protocol versions with an older OpenSSL?

It will be useful to lookup and point to if any users have this problem in the future, since
you mentioned that the error messages aren't very clear in the JIRA.


http://gerrit.cloudera.org:8080/#/c/7866/1/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

PS1, Line 185: system OpenSSL
"linked OpenSSL library" for clarity? Should users choose to link it to a non-system library.


-- 
To view, visit http://gerrit.cloudera.org:8080/7866
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20c5d39c0c4ae9c5445dd3ee3b175fe337a5728d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message