impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0
Date Tue, 29 Aug 2017 17:37:52 GMT
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7859/4/source/thrift/thrift-0.9.0-patches/0011-CLD-Patch-11-IMPALA-5849-Don-t-use-compile-time-chec.patch
File source/thrift/thrift-0.9.0-patches/0011-CLD-Patch-11-IMPALA-5849-Don-t-use-compile-time-chec.patch:

PS4, Line 35: SSL_OP_NO_TLSv1_2 0x08000000L
I'm a tad bit confused; if OpenSSL can't understand these options, and we pass them into SSL_CTX_set_options(),
what's the expected behavior?

Ideally it would be to return with an error (as opposed to undefined behavior), but have we
tested that's what happens?


-- 
To view, visit http://gerrit.cloudera.org:8080/7859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I437703b2221cba6a2c3079c540ccbda571f8db0e
Gerrit-PatchSet: 4
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message