impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5830: SET DENY RESERVATION PROBABILITY test
Date Tue, 29 Aug 2017 15:24:26 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-5830: SET_DENY_RESERVATION_PROBABILITY test
......................................................................


Patch Set 2:

(3 comments)

Mostly naming/commenting nits.

http://gerrit.cloudera.org:8080/#/c/7809/2/tests/query_test/test_spilling.py
File tests/query_test/test_spilling.py:

PS2, Line 33: TestSpilling
Does it make sense to call this TestSpillingDebugActionDimensions ?

Or, consider adding a comment here that's similar to L72.


PS2, Line 71: TestSpillingNoDebugAction
Maybe append Dimensions to this name? At least one test uses debug actions, just using query
options.


PS2, Line 95:       setting debug_action to alternative values
Maybe append the comment "via query options".


-- 
To view, visit http://gerrit.cloudera.org:8080/7809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida6b55b2dee0779b1739af5d75943518ec40d6ce
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message