impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5853: GetResultSetMetadata() invalid query id error message is confusing
Date Mon, 28 Aug 2017 22:30:39 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5853: GetResultSetMetadata() invalid query id error message is confusing
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7863/1//COMMIT_MSG
Commit Message:

Line 7: IMPALA-5853: GetResultSetMetadata() invalid query id error message is confusing
Nit: say what you did, not what was wrong.


http://gerrit.cloudera.org:8080/#/c/7863/1/tests/hs2/test_hs2.py
File tests/hs2/test_hs2.py:

PS1, Line 276: print get_result_set_metadata_resp.status.errorMessage
I don't think this should be here, nor on line 265. It would get printed if the assert failed
anyhow.


-- 
To view, visit http://gerrit.cloudera.org:8080/7863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I51eecf353f9cecaf88cecc9392b08ac1b9326b66
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message