impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4856: Include KRPC services in plan fragment's destinations
Date Mon, 28 Aug 2017 21:30:40 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-4856: Include KRPC services in plan fragment's destinations
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/7760/3/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

Line 1660:         MakeNetworkAddress(ip, FLAGS_krpc_port));
> Either way seems fine to me but we still need to propagate the port number 
No, let's not put the port in here separately.  Leaving krpc_svc_address is okay with me.


http://gerrit.cloudera.org:8080/#/c/7760/3/common/thrift/ImpalaInternalService.thrift
File common/thrift/ImpalaInternalService.thrift:

Line 410:   // the address of the KRPC services on the destination
does this have to be resolved IP as well?


http://gerrit.cloudera.org:8080/#/c/7760/3/common/thrift/StatestoreService.thrift
File common/thrift/StatestoreService.thrift:

Line 72:   // Network address of KRPC services on this backend
this one has to be a resolved IP, right? let's make that clear.


-- 
To view, visit http://gerrit.cloudera.org:8080/7760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8707bfb5028bbe81d2a042fcf3e6e19f4b719a72
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message