impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4856: Include KRPC services in plan fragment's destinations
Date Mon, 28 Aug 2017 19:51:09 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4856: Include KRPC services in plan fragment's destinations
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7760/3/be/src/scheduling/scheduler.cc
File be/src/scheduling/scheduler.cc:

Line 96:     local_backend_descriptor_.__set_krpc_svc_address(krpc_svc_addr);
> why does that have to get saved in the backend descriptor? since the port i
Is your question why it has to be saved to the local backend descriptor? Or why any backend
descriptor at all? For the former, it seems easier to manage all nodes uniformly. For the
latter, the port may not be constant across the cluster (think about the minicluster scenario,
for example).


-- 
To view, visit http://gerrit.cloudera.org:8080/7760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8707bfb5028bbe81d2a042fcf3e6e19f4b719a72
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message