impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection
Date Fri, 25 Aug 2017 22:55:08 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7834/3/testdata/workloads/functional-query/queries/QueryTest/admission-reject-min-reservation.test
File testdata/workloads/functional-query/queries/QueryTest/admission-reject-min-reservation.test:

PS3, Line 33: Mem available for buffer reservations
            :  (based on mem_limit): 1.00 KB
I thought the mem_limit value would go inside the parentheses. Or did you intend the value
shown to be the reservation limit?


-- 
To view, visit http://gerrit.cloudera.org:8080/7834
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3dc3517195508d86078a8a4b537ae7d2f52fbcb7
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message