impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5846: Fix output path for kudu libraries
Date Fri, 25 Aug 2017 21:36:35 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5846: Fix output path for kudu libraries
......................................................................


Patch Set 1: Code-Review+2

I took a quick look at the cmake docs and I also don't fully understand what was wrong with
the old code. However the new code seems to match what is recommended.

-- 
To view, visit http://gerrit.cloudera.org:8080/7818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73f3dd5435bceb35bc929ff6d5f2c92300e2a1d2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message