impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer
Date Fri, 25 Aug 2017 19:15:46 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer
......................................................................


Patch Set 7:

I wonder if you could write a test in thrift-server-test, that did something like the following:

1. Create a server with max N concurrent cnxns (for a low N - 1 or 2)
2. Start M >> N threads, each of which creates a connection, increments a shared counter,
sleeps for a few ms, decrements the shared counter, and then closes the connection.
3. Have the test assert if the shared counter ever goes above N. 

It's not quite perfect (because you can't guarantee that the thread scheduler isn't serializing
the connection requests, not the thrift server), but it would give some confidence. You could
also record the max concurrent connections in the thrift server and check that after the test
has finished.

-- 
To view, visit http://gerrit.cloudera.org:8080/7061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56a5f3d9cf931cff14eae7f236fea018236a6255
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Sherman <jfs@arcadiadata.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: John Sherman <jfs@arcadiadata.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message