impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5836: Improvements to Eclipse frontend configuration.
Date Fri, 25 Aug 2017 02:58:16 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5836: Improvements to Eclipse frontend configuration.
......................................................................


IMPALA-5836: Improvements to Eclipse frontend configuration.

Having recently gone through setting up Eclipse for frontend debugging,
I'm amending the process a tad to make it smoother for new developers.

* Adds the JDK sources package to the developer bootstrap
  process. These are useful if you need to point Eclipse to the source
  of Java libraries and are harmless to everyone else.
* Defaults to "downloadSource" for the "mvn eclipse:eclipse" plugin.
  This was being set explicitly in the Wiki instructions, but
  there's no reason not to set it on by default for everyone.
* Adds a "launcher" file for debugging the FE. Instead of creating
  a debug configuration manually, it's possible to share these across
  developers by checking them in. I checked it in via a mechanism
  that "mvn eclipse:eclipse" has to create additional files, to
  avoid literring the directory for non-Eclipse users.
* Changes the output directory used by Eclipse's compiler to
  a different one than Maven uses. Because we start Impala
  from the commandline, it's easy to start Impala and then
  change a line of Java, which forces Eclipse to kick in and
  replace the .class files. When this happens, the existing Impala
  starts complaining about class not found, because the underlying
  files have been overwritten. It's preferable to separate the
  directories and rely on Maven for the compiled Java.

Change-Id: Ia723fbf706cf409a8fb6b5ff0297c2b1ff7c9590
Reviewed-on: http://gerrit.cloudera.org:8080/7803
Reviewed-by: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Tested-by: Impala Public Jenkins
---
M bin/bootstrap_development.sh
M fe/pom.xml
2 files changed, 41 insertions(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Verified
  Dimitris Tsirogiannis: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7803
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia723fbf706cf409a8fb6b5ff0297c2b1ff7c9590
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins

Mime
View raw message