impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4856: Include KRPC services in plan fragment's destinations
Date Thu, 24 Aug 2017 23:57:03 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4856: Include KRPC services in plan fragment's destinations
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/7760/2/be/src/runtime/exec-env.cc
File be/src/runtime/exec-env.cc:

PS2, Line 172: DCHECK_GT(FLAGS_krpc_port, 0);
Add a TODO to add this to the c'tor - better to reduce the dependency on flags for configuration
inside ExecEnv.


http://gerrit.cloudera.org:8080/#/c/7760/2/be/src/scheduling/backend-config.h
File be/src/scheduling/backend-config.h:

PS2, Line 62: TBackendDescriptor
Comment on lifetime of pointer.


http://gerrit.cloudera.org:8080/#/c/7760/2/be/src/scheduling/scheduler.cc
File be/src/scheduling/scheduler.cc:

PS2, Line 95:  TNetworkAddress krpc_svc_addr = MakeNetworkAddress(ip, FLAGS_krpc_port);
can't you get this from ExecEnv::GetInstance instead?


http://gerrit.cloudera.org:8080/#/c/7760/2/be/src/scheduling/scheduler.h
File be/src/scheduling/scheduler.h:

Line 323:   /// backend or the local host itself.
comment on lifetime of return value.


-- 
To view, visit http://gerrit.cloudera.org:8080/7760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8707bfb5028bbe81d2a042fcf3e6e19f4b719a72
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message