impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3642: Adding backend addresses to error statuses for scratch failures.
Date Thu, 24 Aug 2017 22:11:49 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3642: Adding backend addresses to error statuses for scratch failures.
......................................................................


Patch Set 1:

We have test coverage for scratch errors in a few places:

  be/src/runtime/bufferpool/buffer-pool-test.cc
  be/src/runtime/tmp-file-mgr-test.cc
  tests/custom_cluster/test_scratch_disk.py

There are a bunch of write error tests and a single read error test: BufferPoolTest::ScratchReadError

The backend unit tests check the error codes but not the error messages - one option is to
extend them to check the error messages.

I haven't fully thought through how it would work out, but it might be easier to add this
information to the error message in be/src/tmp-file-mgr.cc.  The write errors get rolled up
into a SCRATCH_ALLOCATION_FAILED message (there may be more than one per disk). There are
also a couple of other error types that emanate from that file: SCRATCH_LIMIT_EXCEEDED and
SCRATCH_READ_TRUNCATED.

-- 
To view, visit http://gerrit.cloudera.org:8080/7816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If31a50fdf6031312d0348d48aeb8f9688274cac2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message