impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build
Date Thu, 24 Aug 2017 21:39:39 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
......................................................................


Patch Set 14:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5719/14/be/src/kudu/rpc/CMakeLists.txt
File be/src/kudu/rpc/CMakeLists.txt:

PS14, Line 97:     # Added by Impala: kudu_util depends on libCommon
             :     ${IMPALA_LINK_LIBS}
> This will create cyclic dependency as the macro KRPC_GENERATE will depend o
Fair point. I took a more surgical approach - let me know what you think?


-- 
To view, visit http://gerrit.cloudera.org:8080/5719
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33203e95dff07c87a6ec5c7a31b7a583b91849bc
Gerrit-PatchSet: 14
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message