impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5108: Followup change to do the cleanup.
Date Thu, 24 Aug 2017 16:51:48 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5108: Followup change to do the cleanup.
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7801/1/be/src/service/session-expiry-test.cc
File be/src/service/session-expiry-test.cc:

PS1, Line 83: (
nit: extraneous parenthesis


PS1, Line 89: (MAX_IDLE_TIMEOUT_MS/1000)
nit: extraneous parenthesis and should have space around /


-- 
To view, visit http://gerrit.cloudera.org:8080/7801
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I521e7e493e4ae26e1955861637cd31f5f678dd0b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message