impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pranay Singh (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5108: idle session timeout kicks in later than expected
Date Thu, 24 Aug 2017 04:46:52 GMT
Pranay Singh has posted comments on this change.

Change subject: IMPALA-5108: idle_session_timeout kicks in later than expected
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7791/1//COMMIT_MSG
Commit Message:

PS1, Line 9: The issue was caused because sessions could get closed
           : some time after their timeout expires, because the session
           : expiration thread only woke up every session-timeout/2
           : seconds. This fix changes the logic, now the session expiration
           : thread will wakeup every 1 sec to check whether sessions can
           : be expired.
           : 
           : The test changes in session-expiry-test is based on introducing
           : variable names for the numeric constants and to reduce the time
           : of max_idle_timeout_ms
> given that the original change was already merged (I wasn't aware of that s
I had reduced MAX_IDLE_TIMEOUT_MS from 5 sec to 4 sec because the session timeout is 1 sec
for all the five sessions, so the delay of 5 sec appeared to be a longer delay, waiting for
sessions to expire. Since the expiration thread is checking for the sessions to be expired
every sec.


-- 
To view, visit http://gerrit.cloudera.org:8080/7791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72625dcc72764c1b89eb4ecb8725c51c9ca7835b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Pranay Singh
Gerrit-HasComments: Yes

Mime
View raw message