impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sherman (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer
Date Wed, 23 Aug 2017 23:23:30 GMT
John Sherman has posted comments on this change.

Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer
......................................................................


Patch Set 6:

(1 comment)

I haven't created the automated test yet, I will try to create one in the next few days. I
did manually test the behavior, but it's always good to have regression tests.

My run-all-tests.sh mostly passed, I did have issues with kudu. I think those errors are probably
related to the lack of memory on my test machine.

http://gerrit.cloudera.org:8080/#/c/7061/6/be/src/benchmarks/network-perf-benchmark.cc
File be/src/benchmarks/network-perf-benchmark.cc:

Line 227:                      .max_concurrent_connections(100)
I went with max_concurrent_connections vs max_concurrent_cnxns, but my choice might be too
verbose. I can change it to the suggested max_concurrent_cnxns if you think that is preferable.


-- 
To view, visit http://gerrit.cloudera.org:8080/7061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56a5f3d9cf931cff14eae7f236fea018236a6255
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Sherman <jfs@arcadiadata.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: John Sherman <jfs@arcadiadata.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message