impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5108: idle session timeout kicks in later than expected
Date Wed, 23 Aug 2017 23:01:28 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5108: idle_session_timeout kicks in later than expected
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7791/1//COMMIT_MSG
Commit Message:

PS1, Line 9: The issue was caused because sessions could get closed
           : some time after their timeout expires, because the session
           : expiration thread only woke up every session-timeout/2
           : seconds. This fix changes the logic, now the session expiration
           : thread will wakeup every 1 sec to check whether sessions can
           : be expired.
           : 
           : The test changes in session-expiry-test is based on introducing
           : variable names for the numeric constants and to reduce the time
           : of max_idle_timeout_ms
given that the original change was already merged (I wasn't aware of that since it showed
up as two separate reviews), this text doesn't apply to this particular change. Just say that
this is a follow up cleanup change.

I'm still curious as to the reason the MAX_IDLE_TIMEOUT_MS was reduced from 5 to 4 seconds.


http://gerrit.cloudera.org:8080/#/c/7791/1/be/src/service/session-expiry-test.cc
File be/src/service/session-expiry-test.cc:

PS1, Line 88:  
nit: nuke that trailing whitespace


-- 
To view, visit http://gerrit.cloudera.org:8080/7791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72625dcc72764c1b89eb4ecb8725c51c9ca7835b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message