impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests
Date Wed, 23 Aug 2017 22:44:31 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7787/1/testdata/workloads/functional-query/queries/QueryTest/spilling-sorts-exhaustive.test
File testdata/workloads/functional-query/queries/QueryTest/spilling-sorts-exhaustive.test:

Line 197: # Test that we can spill with a buffer size larger than the default I/O size (8mb).
worth writing a similar test for join/agg?


-- 
To view, visit http://gerrit.cloudera.org:8080/7787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I03de00394bb6bbcf381250f816e22a4b987f1135
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message