impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages
Date Wed, 23 Aug 2017 22:29:52 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5811: Add 'backends' tab to query details pages
......................................................................


Patch Set 5:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/7711/5/be/src/runtime/coordinator-backend-state.cc
File be/src/runtime/coordinator-backend-state.cc:

Line 571:   value->AddMember("done", IsDone(), document->GetAllocator());
> 'done' is more of an internal concept now (and I think that's better), so n
I think it's useful, even as a derived value - users of this page want to see which backends
are still working on a query (e.g. to see which is hung).


PS5, Line 580: last_heard_from
> that name doesn't sound like a relative time. maybe time_since_last_report 
Done


http://gerrit.cloudera.org:8080/#/c/7711/5/be/src/runtime/coordinator-backend-state.h
File be/src/runtime/coordinator-backend-state.h:

Line 116:   void ToJson(rapidjson::Value* value, rapidjson::Document* doc);
> let's add a quick comment for that.
Done


Line 219:   int64_t last_report_time_ms_ = 0;
> specify what clock that is. is it unix millis or monotoic millis or somethi
Done


http://gerrit.cloudera.org:8080/#/c/7711/5/be/src/runtime/coordinator.h
File be/src/runtime/coordinator.h:

Line 190:   void BackendsToJson(rapidjson::Document* document);
> document
Done


http://gerrit.cloudera.org:8080/#/c/7711/5/be/src/service/impala-http-handler.h
File be/src/service/impala-http-handler.h:

Line 94:   void QueryBackendsHandler(
> document
Done - I haven't followed the other examples of providing an example json document as I think
that's a little verbose, and tightly coupled to the implementation.


-- 
To view, visit http://gerrit.cloudera.org:8080/7711
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5b3b0fb8f4188da56da593199f41ce6fab99767
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message