impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5775: (Addendum) Make SSL cluster actually come up in test client ssl.py
Date Wed, 23 Aug 2017 22:17:29 GMT
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-5775: (Addendum) Make SSL cluster actually come up in test_client_ssl.py
......................................................................


Patch Set 1: Code-Review+2

I agree with the fix, however, we don't have bi-directional hostname verification turned on
(as that's the default in the Thrift SSL transport), so this was already a known issue. That's
something we might want to expose as an option later to catch these kind of bad configurations.

-- 
To view, visit http://gerrit.cloudera.org:8080/7732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idad8bbf3b8be853d3406bcbaed24909501500ea9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message