impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Hide some deprecated flags
Date Wed, 23 Aug 2017 21:55:53 GMT
Lars Volker has posted comments on this change.

Change subject: Hide some deprecated flags
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7786/1//COMMIT_MSG
Commit Message:

Line 7: Hide some deprecated flags
> There isn't a JIRA number. Is one necessary? For tiny changes like this we 
I thought we decided a while ago to always include one, but I may be wrong. Either way is
fine with me. :)


http://gerrit.cloudera.org:8080/#/c/7786/1/be/src/exec/exec-node.cc
File be/src/exec/exec-node.cc:

PS1, Line 74: Deprecated - has no effect
> Since the message isn't user-visible after the flag is hidden, what would b
I assumed those would be visible to the users. If not, then there's no benefit and any message
is fine of course.


-- 
To view, visit http://gerrit.cloudera.org:8080/7786
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I948b46cd6853f1d8ebaaadaba7b801dca886c7ad
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message