impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Hide some deprecated flags
Date Wed, 23 Aug 2017 21:40:17 GMT
Lars Volker has posted comments on this change.

Change subject: Hide some deprecated flags
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7786/1//COMMIT_MSG
Commit Message:

Line 7: Hide some deprecated flags
Can you add a JIRA number? Can you also comment on what the effect of the hidden flags is?
Are they just ignored or do we issue a warning during startup?


http://gerrit.cloudera.org:8080/#/c/7786/1/be/src/exec/exec-node.cc
File be/src/exec/exec-node.cc:

PS1, Line 74: Deprecated - has no effect
Can we use the same error message for deprecated flags across all files?


-- 
To view, visit http://gerrit.cloudera.org:8080/7786
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I948b46cd6853f1d8ebaaadaba7b801dca886c7ad
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message