impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages
Date Wed, 23 Aug 2017 20:41:45 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5811: Add 'backends' tab to query details pages
......................................................................


Patch Set 3:

(2 comments)

Added a test, thanks for the suggestion!

http://gerrit.cloudera.org:8080/#/c/7711/3/be/src/runtime/coordinator-backend-state.cc
File be/src/runtime/coordinator-backend-state.cc:

PS3, Line 557: IsDone
> after Thomas' change, the callers of this are responsible for taking the lo
Done


PS3, Line 566: last_report_time_ms_
> This function is inconsistent about whether it acquires 'lock_' when readin
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7711
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5b3b0fb8f4188da56da593199f41ce6fab99767
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message