impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5713: always reserve memory for preaggs
Date Wed, 23 Aug 2017 20:32:46 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5713: always reserve memory for preaggs
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7739/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java
File fe/src/main/java/org/apache/impala/planner/AggregationNode.java:

PS2, Line 326: one buffer per partition plus 64kb
             :         // per hash table
> that's a bit confusing since hash tables are also per partition. is this eq
Done


PS2, Line 327: 4096 * 16kb buckets
> also what is that saying? what is 4096 and 16kb?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b544f9ec1a906719e2bbb074743926b95a3a573
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message