impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5713: always reserve memory for preaggs
Date Wed, 23 Aug 2017 20:07:19 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5713: always reserve memory for preaggs
......................................................................


Patch Set 2:

> I'm not 100% confident this is the optimal thing to do, but it
 > avoids the possibility of some pretty bad perf regressions in
 > memory-constrained scenarios.

Before buffer-pool, when under memory pressure, was it not possible to also get into a pass-through-everything
mode?

-- 
To view, visit http://gerrit.cloudera.org:8080/7739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b544f9ec1a906719e2bbb074743926b95a3a573
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message