impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5823: fix SET DENY RESERVATION PROBABILITY
Date Wed, 23 Aug 2017 17:54:45 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5823: fix SET_DENY_RESERVATION_PROBABILITY
......................................................................


Patch Set 6:

Missed responding to the DCHECK comment. I don't think there's a clear invariant here. I think
we could write a regression test though, so I filed IMPALA-5830

-- 
To view, visit http://gerrit.cloudera.org:8080/7771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib26b697544d6c2312a8e1fe91b0cf8c0917e5603
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message