impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip Zeyliger (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.
Date Wed, 23 Aug 2017 16:49:21 GMT
Philip Zeyliger has posted comments on this change.

Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.
......................................................................


Patch Set 3:

(2 comments)

Thanks for the quick review! I updated the patch (sorry, took two tries) per your comments.

http://gerrit.cloudera.org:8080/#/c/7781/1//COMMIT_MSG
Commit Message:

PS1, Line 7: :
> nit: use colon
Done


http://gerrit.cloudera.org:8080/#/c/7781/1/fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java
File fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java:

Line 271
> not sure what the diff on this line is but maybe your editor is doing somet
Oddly enough, this previously didn't have a newline at the end of the file. This was, indeed,
corrected by my editor. To avoid the noise, I put it back the way it was.

$git show | grep -C1 'No newline'
-}
\ No newline at end of file
+}

head -c -1 fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java | sponge
fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java


-- 
To view, visit http://gerrit.cloudera.org:8080/7781
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e4b8bf6fedd595f9ea54ffb30fc71a058c7f16c
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message