impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5108: idle session timeout kicks in later than expected
Date Wed, 23 Aug 2017 00:33:49 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5108: idle_session_timeout kicks in later than expected
......................................................................


Patch Set 1:

(8 comments)

Great to see this one get fixed.

http://gerrit.cloudera.org:8080/#/c/7729/1//COMMIT_MSG
Commit Message:

PS1, Line 17: reduce
what's the reason to reduce this time?


Line 18:     of max_idle_timeout_ms
let's generally keep the messages left justified (exception inside formatted structures e.g.
bulleted lists).


http://gerrit.cloudera.org:8080/#/c/7729/1/be/src/service/session-expiry-test.cc
File be/src/service/session-expiry-test.cc:

PS1, Line 68: gets one session eac
since we're really trying to create multiple sessions (and just using clients to do that)
maybe NUM_CLIENTS should be called NUM_SESSIONS?


PS1, Line 83: 10
that looks like it should be expressed in terms of NUM_CLIENTS.


PS1, Line 87: 5s
5s should be updated if you're changing that value.


PS1, Line 87: 10L
same


PS1, Line 88: 5L
isn't that NUM_CLIENTS?


PS1, Line 90: 5L
same


-- 
To view, visit http://gerrit.cloudera.org:8080/7729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I827a5fa2246e7b05b718fb8b4563b8488c91a1d9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message