impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5823: fix SET DENY RESERVATION PROBABILITY
Date Wed, 23 Aug 2017 00:23:45 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5823: fix SET_DENY_RESERVATION_PROBABILITY
......................................................................


Patch Set 3:

(5 comments)

The check below prevented us trying to set the flag on an unregistered client, so we didn't
crash. The debug action was just totally ineffective.
  
  if (buffer_pool_client_.is_registered()) {

http://gerrit.cloudera.org:8080/#/c/7771/3//COMMIT_MSG
Commit Message:

PS3, Line 10: This
> what is "this" referring to? what always worked?
This paragraph was totally wrong - it described a solution that didn't work. Sorry for the
confusion.


Line 17: partitions in the next round of repartitioning.
> and the check is unnecessary since we always give up at some depth, right?
Yeah we hit MAX_PARTITION_DEPTH.


http://gerrit.cloudera.org:8080/#/c/7771/3/be/src/exec/exec-node.cc
File be/src/exec/exec-node.cc:

PS3, Line 249: before
> wasn't sure what that meant. how about "during prepare or open."
Done


Line 250:     LOG(INFO) << "DEBUG ACTION FIRED";
Don't need this logging.


PS3, Line 260: EnableIncreaseReservationDebugAction
> I think it's clearer with "deny" in the name. EnableDenyReservationDebugAct
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib26b697544d6c2312a8e1fe91b0cf8c0917e5603
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message