impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5823: fix SET DENY RESERVATION PROBABILITY
Date Wed, 23 Aug 2017 00:14:21 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5823: fix SET_DENY_RESERVATION_PROBABILITY
......................................................................


Patch Set 3:

(4 comments)

Why didn't this bug result in a crash (impl_ == nullptr)?

http://gerrit.cloudera.org:8080/#/c/7771/3//COMMIT_MSG
Commit Message:

PS3, Line 10: This
what is "this" referring to? what always worked?


Line 17: partitions in the next round of repartitioning.
and the check is unnecessary since we always give up at some depth, right?


http://gerrit.cloudera.org:8080/#/c/7771/3/be/src/exec/exec-node.cc
File be/src/exec/exec-node.cc:

PS3, Line 249: before
wasn't sure what that meant. how about "during prepare or open."


PS3, Line 260: EnableIncreaseReservationDebugAction
I think it's clearer with "deny" in the name. EnableDenyReservationDebugAction?


-- 
To view, visit http://gerrit.cloudera.org:8080/7771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib26b697544d6c2312a8e1fe91b0cf8c0917e5603
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message