impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3208: max row size option
Date Tue, 22 Aug 2017 23:17:59 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-3208: max_row_size option
......................................................................


Patch Set 14:

(3 comments)

FE changes look good to me. Thanks for giving me a chance to look. Please go ahead and merge.

http://gerrit.cloudera.org:8080/#/c/7629/14//COMMIT_MSG
Commit Message:

Line 26: per read and write iterator, and temporarily requires reservation
Is this temporary reservation instead of or in addition to the default-sized reservation?
(Just for my understanding, no need to change anything)


http://gerrit.cloudera.org:8080/#/c/7629/14/common/thrift/ImpalaInternalService.thrift
File common/thrift/ImpalaInternalService.thrift:

Line 268:   // rows larger than this may result in a query failure. Defaults to 512KB, e.g.
Let's be sure to add the change in default to the list of incompatible changes.


http://gerrit.cloudera.org:8080/#/c/7629/14/testdata/workloads/functional-planner/queries/PlannerTest/max-row-size.test
File testdata/workloads/functional-planner/queries/PlannerTest/max-row-size.test:

Line 21: 02:HASH JOIN [INNER JOIN, BROADCAST]
We may eventually want to create a simpler test framework for resource planner tests like
this, e.g. more along the lines of analyzer tests. Dumping the whole plan text at this verbosity
will require many future updates to this file.


-- 
To view, visit http://gerrit.cloudera.org:8080/7629
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic70f6dddbcef124bb4b329ffa2e42a74a1826570
Gerrit-PatchSet: 14
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message